Sunday, July 16, 2017

Policy Plus - Non-English improvements

Policy Plus received it's first official GitHub issue report a day or so ago. On French Windows 10, the program gives an error at startup, saying that it cannot load policy definitions. Upon investigation in a French Windows 10 VM, I found that this comes down to a globalization problem. In French, the decimal separator is apparently the comma. In English (and in the ADMX and ADML formats), it's a period. Policy Plus used the normal .NET parsing method to comprehend the decimal number in the version field of those files, but .NET used the user's culture settings, so the decimal point was not recognized and the parsing failed. I fixed that problem by using the invariant culture to parse decimal numbers.

Then I found that Policy Plus errored again, being unable to find the ADML file for a certain ADMX, while the LGPE had no problem. Evidently, the LGPE falls back to English ADML files if another language's ADML associated with an ADMX is not present. Policy Plus now does this too. These two changes, now live on GitHub, fixed that user's problem.

No comments:

Post a Comment